increment fixed drive on lost fumbles with play type pass, run or punt #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #418
We already incremented fixed drive on lost fumbles (with later recovery in the same play) of punts and on interceptions.
We didn't do it for run plays nor did we for pass plays with completed passes.
The missing run plays were the cause of #418. But there were about 20 other plays from 1999:2022 affected by not doing it on completed passes.
I changed it to increment on punt, pass and run (for now). It fixes all relevant plays and doesn't change anything else. So this should be good to go.